gtk: fix missing newline in formatted config#2809
Merged
berbiche merged 1 commit intonix-community:masterfrom Mar 20, 2022
polykernel:fix-config-concatenation
Merged
gtk: fix missing newline in formatted config#2809berbiche merged 1 commit intonix-community:masterfrom polykernel:fix-config-concatenation
berbiche merged 1 commit intonix-community:masterfrom
polykernel:fix-config-concatenation
Conversation
The conversion from `concatMapStrings` to `concatStringsSep` introduced in #2481 creates an unintended behavior change where the formatted config does not end in a newline.[1] This is problematic for manipulation at the Nix level. In particular, this cause a regression in the generation of gtk2 settings due to concatenated of the formatted config and `gtk2.extraConfig` without a newline in between. This commit restores `concatMapStrings` to match the previous behavior and adds a newline to the final string for the generated gtk2 config. The test case for gtk2-basic-config was also updated to check behavior at concatenation boundaries. [1] - #2481 (comment)
jficz
pushed a commit
to jficz/home-manager
that referenced
this pull request
Apr 7, 2022
The conversion from `concatMapStrings` to `concatStringsSep` introduced in nix-community#2481 creates an unintended behavior change where the formatted config does not end in a newline.[1] This is problematic for manipulation at the Nix level. In particular, this cause a regression in the generation of gtk2 settings due to concatenated of the formatted config and `gtk2.extraConfig` without a newline in between. This commit restores `concatMapStrings` to match the previous behavior and adds a newline to the final string for the generated gtk2 config. The test case for gtk2-basic-config was also updated to check behavior at concatenation boundaries. [1] - nix-community#2481 (comment)
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
The conversion from `concatMapStrings` to `concatStringsSep` introduced in nix-community#2481 creates an unintended behavior change where the formatted config does not end in a newline.[1] This is problematic for manipulation at the Nix level. In particular, this cause a regression in the generation of gtk2 settings due to concatenated of the formatted config and `gtk2.extraConfig` without a newline in between. This commit restores `concatMapStrings` to match the previous behavior and adds a newline to the final string for the generated gtk2 config. The test case for gtk2-basic-config was also updated to check behavior at concatenation boundaries. [1] - nix-community#2481 (comment)
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
The conversion from `concatMapStrings` to `concatStringsSep` introduced in nix-community#2481 creates an unintended behavior change where the formatted config does not end in a newline.[1] This is problematic for manipulation at the Nix level. In particular, this cause a regression in the generation of gtk2 settings due to concatenated of the formatted config and `gtk2.extraConfig` without a newline in between. This commit restores `concatMapStrings` to match the previous behavior and adds a newline to the final string for the generated gtk2 config. The test case for gtk2-basic-config was also updated to check behavior at concatenation boundaries. [1] - nix-community#2481 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion from
concatMapStringstoconcatStringsSepintroduced in #2481creates an unintended behavior change where the formatted config does not end in a newline.[1]
This is problematic for manipulation at the Nix level. In particular, this cause a regression in
the generation of gtk2 settings due to concatenated of the formatted config and
gtk2.extraConfigwithout a newline in between.
This commit restores
concatMapStringsto match the previous behavior and adds a newline tothe final string for the generated gtk2 config. The test case for gtk2-basic-config
was also updated to check behavior at concatenation boundaries.
[1] - #2481 (comment)
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.