xcursor: remove warning and use mkDefault for GTK options#2808
Merged
berbiche merged 1 commit intonix-community:masterfrom Mar 20, 2022
Merged
xcursor: remove warning and use mkDefault for GTK options#2808berbiche merged 1 commit intonix-community:masterfrom
berbiche merged 1 commit intonix-community:masterfrom
Conversation
7 tasks
elasticdog
added a commit
to elasticdog/snowflakes
that referenced
this pull request
Mar 28, 2022
…sor" This reverts commit ea7885a. It looks like the deprecation warning was subsequently removed and a different approach to de-duplicating cursor settings is still being worked on upstream. See: - nix-community/home-manager#2808 - nix-community/home-manager#2481
jficz
pushed a commit
to jficz/home-manager
that referenced
this pull request
Apr 7, 2022
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See discussion at #2481 (comment).
I'd like this to be merged quickly as I think the warning will only create confusion and cause users to stop using the xcursor module. Then we can decide how to structure cursor options at peace.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.