Skip to content

xsession.pointerCursor: escape special characters in the cursor path#2805

Merged
sumnerevans merged 1 commit intonix-community:masterfrom
polykernel:xcursor-quote-path
Mar 21, 2022
Merged

xsession.pointerCursor: escape special characters in the cursor path#2805
sumnerevans merged 1 commit intonix-community:masterfrom
polykernel:xcursor-quote-path

Conversation

@polykernel
Copy link
Copy Markdown
Contributor

@polykernel polykernel commented Mar 19, 2022

  • Escape special character in the cursor name and default cursor file name
    in the cursor path for the xsetroot command.

Description

small change to address #2081 (comment)

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@polykernel polykernel requested a review from league as a code owner March 19, 2022 03:18
Comment thread modules/xcursor.nix Outdated
Copy link
Copy Markdown
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the commit description to reflect what you actually did here? (It's not wrapping in quotes anymore)

Comment thread modules/xcursor.nix Outdated
- Escape special character in the cursor name and default cursor file name
  in the cursor path for the xsetroot command.
@polykernel polykernel changed the title xsession.pointerCursor: wrap Xcursor file path in quotes xsession.pointerCursor: escape special characters in the cursor path Mar 20, 2022
@sumnerevans sumnerevans merged commit 835797f into nix-community:master Mar 21, 2022
@polykernel polykernel deleted the xcursor-quote-path branch March 23, 2022 22:54
jficz pushed a commit to jficz/home-manager that referenced this pull request Apr 7, 2022
…ix-community#2805)

- Escape special character in the cursor name and default cursor file name
  in the cursor path for the xsetroot command.
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
…ix-community#2805)

- Escape special character in the cursor name and default cursor file name
  in the cursor path for the xsetroot command.
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
…ix-community#2805)

- Escape special character in the cursor name and default cursor file name
  in the cursor path for the xsetroot command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants