Skip to content

stalebot: disable auto-closing of issues and pull requests#2800

Merged
sumnerevans merged 1 commit intomasterfrom
less-agressive-stalebot
Mar 20, 2022
Merged

stalebot: disable auto-closing of issues and pull requests#2800
sumnerevans merged 1 commit intomasterfrom
less-agressive-stalebot

Conversation

@sumnerevans
Copy link
Copy Markdown
Contributor

Description

Makes the stalebot less aggressive by disabling its auto-close functionality.

Closes #2799

Example rendered messages:

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

@sumnerevans sumnerevans requested a review from berbiche March 18, 2022 01:04
@sumnerevans sumnerevans requested a review from rycee as a code owner March 18, 2022 01:04
@sumnerevans
Copy link
Copy Markdown
Contributor Author

@lilyball FYI

@berbiche
Copy link
Copy Markdown
Member

I propose removing the phrase "if you have nothing of substance to add" as it seems rather aggressive to me.

@sumnerevans
Copy link
Copy Markdown
Contributor Author

Hmm... wondering how else to tell people not to comment "I have this issue too" as that really is not useful and just clutters the inbox of anyone who is watching the repo.

@berbiche
Copy link
Copy Markdown
Member

"I have this issue too"

I don't think we've had much comments like these on HM issues, even before the introduction of the stale bot, though I agree with you that these comments only add noise.
Would this phrase be better "Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome (additional information | contributions) that will help resolve this issue"?

@sumnerevans sumnerevans force-pushed the less-agressive-stalebot branch from c21aa71 to 6ac3075 Compare March 20, 2022 05:00
@sumnerevans sumnerevans force-pushed the less-agressive-stalebot branch from 6ac3075 to 414548c Compare March 20, 2022 05:15
@sumnerevans
Copy link
Copy Markdown
Contributor Author

Changed the wording a bit, going to go ahead and merge this. We can adjust later if necessary.

@sumnerevans sumnerevans merged commit 0fad959 into master Mar 20, 2022
jficz pushed a commit to jficz/home-manager that referenced this pull request Apr 7, 2022
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
@khaneliman khaneliman deleted the less-agressive-stalebot branch April 5, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Stale bot closes valid issues

2 participants