Skip to content

autorandr: add filter option#2795

Merged
uvNikita merged 1 commit intonix-community:masterfrom
somasis:master
Mar 17, 2022
Merged

autorandr: add filter option#2795
uvNikita merged 1 commit intonix-community:masterfrom
somasis:master

Conversation

@somasis
Copy link
Copy Markdown
Member

@somasis somasis commented Mar 15, 2022

Description

xrandr's --filter option is useful for enabling integer scaling on displays that don't have support for it at a graphics card level; autorandr doesn't add this option itself to generated profiles, but happily accepts it if the user adds it to the config.

As an alternative to this change, perhaps an extraConfig attribute would be suitable; I didn't take that approach because I only needed this one option added.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.
    FIXME(?): seems that modules/misc/xdg-desktop-entries.nix made them fail on my machine...?

  • Test cases updated/added.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

xrandr's filter option is useful for enabling integer scaling on
displays that don't have support for it at a graphics card level.
@somasis somasis requested review from rycee and uvNikita as code owners March 15, 2022 14:59
Copy link
Copy Markdown
Collaborator

@uvNikita uvNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uvNikita uvNikita merged commit 970b57f into nix-community:master Mar 17, 2022
jficz pushed a commit to jficz/home-manager that referenced this pull request Apr 7, 2022
xrandr's filter option is useful for enabling integer scaling on
displays that don't have support for it at a graphics card level.
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
xrandr's filter option is useful for enabling integer scaling on
displays that don't have support for it at a graphics card level.
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
xrandr's filter option is useful for enabling integer scaling on
displays that don't have support for it at a graphics card level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants