Skip to content

update i3status-rust default to new format#2774

Merged
berbiche merged 1 commit intonix-community:masterfrom
happysalada:change_i3status_rust_default
Mar 4, 2022
Merged

update i3status-rust default to new format#2774
berbiche merged 1 commit intonix-community:masterfrom
happysalada:change_i3status_rust_default

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

@happysalada happysalada commented Mar 3, 2022

Description

The i3status-rust format has changed. The default in home-manager is not valid format anymore. Without defining a bar, it generates a cryptic error about format and {Mup} .
This PR just updates to the latest format.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the PR.

You'll need to rebase your changes for the pipeline to succeed.

I'm surprised this is coming up since a PR fixed this issue nearly a year ago (but the PR did not update every format_mem and format_swap configuration in the file!).

@happysalada
Copy link
Copy Markdown
Contributor Author

alright, thanks for the heads up, I just rebased.

@happysalada happysalada requested a review from rycee as a code owner March 4, 2022 02:54
@berbiche berbiche merged commit d119cea into nix-community:master Mar 4, 2022
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants