update i3status-rust default to new format#2774
Merged
berbiche merged 1 commit intonix-community:masterfrom Mar 4, 2022
happysalada:change_i3status_rust_default
Merged
update i3status-rust default to new format#2774berbiche merged 1 commit intonix-community:masterfrom happysalada:change_i3status_rust_default
berbiche merged 1 commit intonix-community:masterfrom
happysalada:change_i3status_rust_default
Conversation
berbiche
approved these changes
Mar 4, 2022
Member
There was a problem hiding this comment.
Hi,
Thanks for the PR.
You'll need to rebase your changes for the pipeline to succeed.
I'm surprised this is coming up since a PR fixed this issue nearly a year ago (but the PR did not update every format_mem and format_swap configuration in the file!).
Contributor
Author
|
alright, thanks for the heads up, I just rebased. |
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The i3status-rust format has changed. The default in home-manager is not valid format anymore. Without defining a bar, it generates a cryptic error about format and {Mup} .
This PR just updates to the latest format.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.