Skip to content

vscode: fix name of extension in example#2759

Merged
berbiche merged 1 commit intonix-community:masterfrom
wamserma:fix-vscode-example
Feb 24, 2022
Merged

vscode: fix name of extension in example#2759
berbiche merged 1 commit intonix-community:masterfrom
wamserma:fix-vscode-example

Conversation

@wamserma
Copy link
Copy Markdown
Contributor

Description

Changed name of extension bbenoist.nix to all lowercase as nix would complain about a missing Nix attribute otherwise.

Checklist

  • Minor typo fix in docs.

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@wamserma wamserma requested a review from rycee as a code owner February 24, 2022 23:14
Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

@berbiche berbiche merged commit 650cfe6 into nix-community:master Feb 24, 2022
@wamserma wamserma deleted the fix-vscode-example branch February 25, 2022 07:21
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants