Skip to content

Add lib argument to homeManagerConfiguration#2753

Merged
berbiche merged 1 commit intonix-community:masterfrom
dwarfmaster:specific-lib
Apr 17, 2022
Merged

Add lib argument to homeManagerConfiguration#2753
berbiche merged 1 commit intonix-community:masterfrom
dwarfmaster:specific-lib

Conversation

@dwarfmaster
Copy link
Copy Markdown
Contributor

@dwarfmaster dwarfmaster commented Feb 23, 2022

Description

Add a lib argument to homeManagerConfiguration to specify the lib to use instead of the one from pkgs.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

@dwarfmaster dwarfmaster requested a review from rycee as a code owner February 23, 2022 16:07
ncfavier
ncfavier approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of curiosity, what is your use case for this?

@dwarfmaster
Copy link
Copy Markdown
Contributor Author

dwarfmaster commented Mar 10, 2022 •
edited
Loading

When I was refactoring my configuration, I was extending lib with some locally defined functions, but when I extended the lib in pkgs I had some infinite recursion, so I had a local pkgs with overlays and a local lib extended with some functions.

I have since noticed that I could use a different pkgs for home-manager, one extended with the complete lib, some I don't need this merged anymore, but since nixosSystem also has an optional lib argument it would make sense for homeManagerConfiguration to also have one.

@ncfavier
Copy link
Copy Markdown
Member

ncfavier commented Mar 10, 2022

OK, you might be interested in the discussion at NixOS/nixpkgs#157056

berbiche
berbiche approved these changes Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Merging after the tests.

@berbiche berbiche merged commit 5ac84eb into nix-community:master Apr 17, 2022
teto pushed a commit to teto/home-manager that referenced this pull request Apr 28, 2022
@dwarfmaster
Add lib argument to homeManagerConfiguration (nix-community#2753)
dd69370
@teto teto mentioned this pull request Aug 22, 2022
Closed
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
@dwarfmaster
Add lib argument to homeManagerConfiguration (nix-community#2753)
1f8a5de
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
@dwarfmaster @spacekookie
Add lib argument to homeManagerConfiguration (nix-community#2753)
dfcb006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncfavier ncfavier ncfavier approved these changes

@berbiche berbiche berbiche approved these changes

@rycee rycee Awaiting requested review from rycee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwarfmaster @ncfavier @berbiche