tmux: add notes to existing keybindings (#2540)#2742
Merged
berbiche merged 1 commit intonix-community:masterfrom Mar 19, 2022
Merged
tmux: add notes to existing keybindings (#2540)#2742berbiche merged 1 commit intonix-community:masterfrom
berbiche merged 1 commit intonix-community:masterfrom
Conversation
Adds notes to the keybindings created in the tmux config making them show up in C-b ? and tmux list-keys -N Fixes nix-community#2540
1 task
jficz
pushed a commit
to jficz/home-manager
that referenced
this pull request
Apr 7, 2022
…munity#2742) Adds notes to the keybindings created in the tmux config making them show up in C-b ? and tmux list-keys -N Fixes nix-community#2540
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
…munity#2742) Adds notes to the keybindings created in the tmux config making them show up in C-b ? and tmux list-keys -N Fixes nix-community#2540
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
…munity#2742) Adds notes to the keybindings created in the tmux config making them show up in C-b ? and tmux list-keys -N Fixes nix-community#2540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds notes to the keybindings created in the tmux config, making them show up when checking
C-b ?ortmux list-keys -N, fixing #2540. I also adjusted the reference configs in the test cases to expect the notes.Keys without notes are not displayed when checking
C-b ?(since tmux 3.1), making them hard to discover for users.The explanations are mostly taken from/based on the tmux man-page (which is licensed under Zero-Clause BSD).
I ran all tests which don't complain about the
shellDryRunattribute missing (see #2722) and all tests that pass without the commit also pass with it (onlyherbstluftwm-simple-configfails, both with and without my commit).Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all. (Mostly of done, see above)Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.