tiny: add module#2735
Merged
berbiche merged 6 commits intonix-community:masterfrom Feb 26, 2022
kmaasrud:tiny
Merged
Conversation
otavio
approved these changes
Feb 19, 2022
berbiche
requested changes
Feb 20, 2022
Member
berbiche
left a comment
berbiche
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
The module follows all our standards 👍
The only nit is that the line added to the CODEOWNERS file is not at the right place.
Contributor
Author
|
I also added the darwin configuration path fix from #2736. tiny seems to respect standard directories, making XDG useless on Darwin. |
ratsclub
approved these changes
Feb 20, 2022
sumnerevans
suggested changes
Feb 21, 2022
tiny follows standard directories, meaning XDG_CONFIG_HOME is useless there. fix is same as #2736 more info: osa1/tiny#297
Contributor
|
Looks like you need to add yourself as a maintainer. Note that I just rebased your branch and force-pushed due to unrelated build failures that just got fixed. |
Contributor
Author
|
Thanks for that @sumnerevans! Added myself to |
sumnerevans
suggested changes
Feb 21, 2022
Contributor
Author
|
Sorry about all the fuzz; I'm a new contributor, as you understand 😅 |
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Mar 2, 2022
Added module for tiny, a TUI IRC client written in Rust. Thanks to @ratsclub for helping me write my first Nix module!
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
Added module for tiny, a TUI IRC client written in Rust. Thanks to @ratsclub for helping me write my first Nix module!
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
Added module for tiny, a TUI IRC client written in Rust. Thanks to @ratsclub for helping me write my first Nix module!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added module for tiny, a TUI IRC client written in Rust. Thanks to @ratsclub for helping me write my first Nix module!
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.