pylint: add module

[florpe]

Description

Adds a module for the Python linter pylint.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[berbiche]

Hi,

This module allows you to configure a global pylintrc configuration file, but can you override this file on a per-project basis without unsetting PYLINTRC?

According to this StackOverflow answer, it's possible to set the file ~/.pylintrc with the user configuration.
IMO this would be a better solution than setting an environment variable as the environment variable will only work correctly if the user has set programs.$SHELL.enable for each shell.

[florpe]

According to the pylint docs, setting PYLINTRC or linking from ~/.pylintrc will have the same effect - in either case $PWD/.pylintrc will take precedence. I see your point about shell integration though, and looking at other modules writing a dotfile seems like the more popular approach anyway, so I'll adjust the PR.

Is there a style guide for decisions like this?

[berbiche]

Could you rebase your changes on the latest "master" to fix the failing test case?

and looking at other modules writing a dotfile seems like the more popular approach anyway, so I'll adjust the PR.

Is there a style guide for decisions like this?

AFAIK we don't currently have any documentation regarding when to use dotfiles or environment variables.
Dotfiles are generally a better idea because they work without needing to source Home Manager's environment variables.
Sometimes we use environment variables by wrapping tools with a script that sets the right environment before starting.

[berbiche]

Small nit, lgtm besides that.

[berbiche]

./modules/programs/pylint.nix: not formatted

Unfortunately the formatting script has to be run again.

[florpe]

It appears nixfmt has some difficulties with the newline in the list separator - now it's just ", ", which is going to be ugly for longer lists, but at least the formatter is happy.

[berbiche]

LGTM!