mpd-discord-rpc: init service#2728
Conversation
berbiche
left a comment
There was a problem hiding this comment.
Thanks, I left some comments until you mark the PR as ready.
4ceeefb to
d65132d
Compare
sumnerevans
left a comment
There was a problem hiding this comment.
Probably also need to rebase to get the latest fixes to the nnn tests.
dc9d928 to
9e1b5ef
Compare
|
Drafting the PR because there has been some changes to the package that I am implementing now. |
|
|
|
Re-adjusted the settings option to work nicer with the new changes in the latest release. Drafting until NixOS/nixpkgs#161510 reaches unstable. |
|
The update hit the nixos-unstable, undrafting. |
berbiche
left a comment
There was a problem hiding this comment.
LGTM!
Thanks again and sorry for the delay.
Description
This PR adds a configurable service that runs mpd-discord-rpc.
I am waiting for the upstream package to merge this pull request JakeStanger/mpd-discord-rpc#16 so the package can be added to nixpkgs.The module has also been tested to be working fine on my personal system with an overlay for the package mpd-discord-rpc
since it is not in nixpkgs yet.,it is now.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.