Skip to content

mpd-discord-rpc: init service#2728

Merged
berbiche merged 1 commit intonix-community:masterfrom
Kranzes:master
Apr 5, 2022
Merged

mpd-discord-rpc: init service#2728
berbiche merged 1 commit intonix-community:masterfrom
Kranzes:master

Conversation

@Kranzes
Copy link
Copy Markdown
Member

@Kranzes Kranzes commented Feb 17, 2022

Description

This PR adds a configurable service that runs mpd-discord-rpc.

I am waiting for the upstream package to merge this pull request JakeStanger/mpd-discord-rpc#16 so the package can be added to nixpkgs.

The module has also been tested to be working fine on my personal system with an overlay for the package mpd-discord-rpc since it is not in nixpkgs yet. ,it is now.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left some comments until you mark the PR as ready.

Comment thread modules/services/mpd-discord-rpc.nix Outdated
Comment thread .github/CODEOWNERS Outdated
@Kranzes Kranzes marked this pull request as ready for review February 21, 2022 13:39
@Kranzes Kranzes requested a review from rycee as a code owner February 21, 2022 13:39
@Kranzes Kranzes requested a review from berbiche February 21, 2022 13:39
@Kranzes Kranzes force-pushed the master branch 3 times, most recently from 4ceeefb to d65132d Compare February 21, 2022 13:48
Copy link
Copy Markdown
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also need to rebase to get the latest fixes to the nnn tests.

Comment thread modules/services/mpd-discord-rpc.nix Outdated
Comment thread modules/services/mpd-discord-rpc.nix Outdated
Comment thread modules/services/mpd-discord-rpc.nix Outdated
Comment thread modules/services/mpd-discord-rpc.nix Outdated
Comment thread modules/services/mpd-discord-rpc.nix Outdated
@Kranzes
Copy link
Copy Markdown
Member Author

Kranzes commented Feb 22, 2022

Drafting the PR because there has been some changes to the package that I am implementing now.

@Kranzes Kranzes marked this pull request as draft February 22, 2022 11:52
@Kranzes
Copy link
Copy Markdown
Member Author

Kranzes commented Feb 22, 2022

Alright I have tested the new changes and they work, I think it's fine to merge this before the new update that support the new options is merged into nixpkgs. It does not error when using an outdated version. NixOS/nixpkgs#161350 merged.

@Kranzes Kranzes marked this pull request as ready for review February 22, 2022 12:26
Comment thread .github/CODEOWNERS Outdated
@Kranzes
Copy link
Copy Markdown
Member Author

Kranzes commented Feb 23, 2022

Re-adjusted the settings option to work nicer with the new changes in the latest release. Drafting until NixOS/nixpkgs#161510 reaches unstable.

@Kranzes Kranzes marked this pull request as draft February 23, 2022 17:19
@Kranzes
Copy link
Copy Markdown
Member Author

Kranzes commented Mar 2, 2022

The update hit the nixos-unstable, undrafting.

@Kranzes Kranzes marked this pull request as ready for review March 2, 2022 10:25
Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread modules/services/mpd-discord-rpc.nix Outdated
Comment thread modules/services/mpd-discord-rpc.nix Outdated
Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks again and sorry for the delay.

@berbiche berbiche merged commit 07b941f into nix-community:master Apr 5, 2022
jficz pushed a commit to jficz/home-manager that referenced this pull request Apr 7, 2022
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants