home-manager: fix home-manager build error#2514
Merged
berbiche merged 1 commit intonix-community:masterfrom Nov 29, 2021
polykernel:home-manager-patch-2
Merged
home-manager: fix home-manager build error#2514berbiche merged 1 commit intonix-community:masterfrom polykernel:home-manager-patch-2
berbiche merged 1 commit intonix-community:masterfrom
polykernel:home-manager-patch-2
Conversation
Two misplaced quotations were introduced in `doBuild` by #2501, which caused the parameter expansion of DRY_RUN to include an extraneous tab. Since the flake uri is passed later into the command, Nix assumes the whitespace sequence as the flake uri and returns that it is not a valid flake reference. This PR removes the misplaced quotations in `doBuild` and also places the flake uri as the first argument for calls to `doBuildFlake` for consistency with `doBuildAttr`. Placing the uri first in the command line also guards against possible security issues if arbitrary uris are expanded prior to the user given uri.
berbiche
approved these changes
Nov 29, 2021
Member
berbiche
left a comment
berbiche
left a comment
There was a problem hiding this comment.
I missed the misplaced quotes in my original review 😔
Thanks for the fix.
|
Is there a process for getting this backported? It's currently broken in |
rycee
pushed a commit
that referenced
this pull request
Dec 2, 2021
Two misplaced quotations were introduced in `doBuild` by #2501, which caused the parameter expansion of DRY_RUN to include an extraneous tab. Since the flake uri is passed later into the command, Nix assumes the whitespace sequence as the flake uri and returns that it is not a valid flake reference. This PR removes the misplaced quotations in `doBuild` and also places the flake uri as the first argument for calls to `doBuildFlake` for consistency with `doBuildAttr`. Placing the uri first in the command line also guards against possible security issues if arbitrary uris are expanded prior to the user given uri. (cherry picked from commit 9de7722)
Member
|
@Prillan Cherry-picked to 21.11 now. |
Amazing, thank you! |
peterhoeg
pushed a commit
to peterhoeg/home-manager
that referenced
this pull request
Dec 6, 2021
Two misplaced quotations were introduced in `doBuild` by nix-community#2501, which caused the parameter expansion of DRY_RUN to include an extraneous tab. Since the flake uri is passed later into the command, Nix assumes the whitespace sequence as the flake uri and returns that it is not a valid flake reference. This PR removes the misplaced quotations in `doBuild` and also places the flake uri as the first argument for calls to `doBuildFlake` for consistency with `doBuildAttr`. Placing the uri first in the command line also guards against possible security issues if arbitrary uris are expanded prior to the user given uri.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two misplaced quotations were introduced in
doBuildby #2501, whichcaused the parameter expansion of DRY_RUN to include an extraneous tab. Since the flake uri is passed
later into the command, Nix assumes the whitespace sequence as the flake uri and returns that it is not
a valid flake reference.
This PR removes the misplaced quotations in
doBuildand also places the flake uri as the first argument forcalls to
doBuildFlakefor consistency withdoBuildAttr. Placing the uri first in the command line also guardsagainst possible security issues if arbitrary uris are expanded prior to the user given uri.
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.