rofi: fix theme definition in configuration for 1.7.0+#2513
Merged
berbiche merged 1 commit intonix-community:masterfrom Nov 28, 2021
Merged
rofi: fix theme definition in configuration for 1.7.0+#2513berbiche merged 1 commit intonix-community:masterfrom
berbiche merged 1 commit intonix-community:masterfrom
Conversation
Since Rofi 1.7.1 (specifically davatorium/rofi@0e70d8a), the deprecated `theme` option in the `configuration` section no longer works. For 1.7.0 and up, `@theme "name"` is supposed to be used *after* the `configuration` block.
Contributor
|
LGTM. |
thiagokokada
approved these changes
Nov 28, 2021
peterhoeg
pushed a commit
to peterhoeg/home-manager
that referenced
this pull request
Dec 6, 2021
…#2513) Since Rofi 1.7.1 (specifically davatorium/rofi@0e70d8a), the deprecated `theme` option in the `configuration` section no longer works. For 1.7.0 and up, `@theme "name"` is supposed to be used *after* the `configuration` block.
Member
|
This could use a backport to the 21.11 branch (see https://discourse.nixos.org/t/trouble-configuring-rofi-theme-in-home-nix/16641) |
rycee
pushed a commit
that referenced
this pull request
Dec 18, 2021
Since Rofi 1.7.1 (specifically davatorium/rofi@0e70d8a), the deprecated `theme` option in the `configuration` section no longer works. For 1.7.0 and up, `@theme "name"` is supposed to be used *after* the `configuration` block. (cherry picked from commit 3ec7f6f)
Member
|
Backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since Rofi 1.7.1 (specifically davatorium/rofi@0e70d8a), the deprecated
themeoption in theconfigurationsection no longer works and throws an error. For 1.7.0 and up (see https://github.com/davatorium/rofi/releases/tag/1.7.0),@theme "name"is supposed to be used and must be after theconfigurationsectionThis PR updates the config generation for this and specifically makes sure
@themegoes lastModule maintainer: @thiagokokada
Checklist
Change is backwards compatible. (Rofi 1.7.0+ which is only in unstable channel)
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.