Improve i3.nix to handle options as list like in sway, adjusted functions for less new-lines

[SebTM]

Description

Issue #2030 should describe it well :)
Didn't fixed the tests yet, just wanted to ask if there is feedback before about the way2go here? :)

Checklist

• Change is backwards compatible.

• Code formatted with ./format.
  Yes but formats some code parts really bad?

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[sumnerevans]

Seems like the right direction. Please update the tests to make sure that you didn't introduce any regressions.

[SebTM]

Fixed the tests, format and adjusted the writeText in i3/sway to follow this approach. Would be nice if you could review it again :)

[berbiche]

Looks good overall.
Would be cool if the indentation could also be preserved.

[SebTM]

Looks good overall. Would be cool if the indentation could also be preserved.

Tried my best in the new commits :)

[SebTM]

Changed everything according feedback, one conversation left because of some things to check back :)
Kudo's to @Ma27 for supporting 🥇

[berbiche]

Could you move the lists.nix changes to a different PR and undo the changes in this PR?

[SebTM]

Could you move the lists.nix changes to a different PR and undo the changes in this PR?

Done, also did my best for the other points of your feedback :) This PR now depends on #2566 where the new lib-function is added (this is why the pipeline fails). Would appreciate your re-review 👍🏻

[SebTM]

Rebased on current master, Cleaned commit :)

[sumnerevans]

Looks like the build is failing for some reason. Can you look into that (oh, I see, it depends on the other PR)?

[sumnerevans]

Looks good, overall.

[SebTM]

Rebased to current master, applied changes from feedback, fixed tests and found lists.subtractLists which does exactly what I needed I guess :)

Tests seem to fail because of the issue in #2767 with PR #2770 pending ✌🏻

[sumnerevans]

Sorry it's taken so long to look over this. I think it looks fine. If you want to try and refactor to avoid the ++ [ "\n" ] then feel free to and I'll have another look.

[SebTM]

Are the failing tests related? I would say no...

herbstluftwm-simple-config: FAILED
Expected /nix/store/hjxvnf979k037q74digq2k64w49z2n69-nmt-report-herbstluftwm-simple-config/normalized/autostart to be same as /nix/store/ci79wirs2xwxb23nfbd3cd14b0g4bzpv-autostart but were different:
--- actual
+++ expected
@@ -1,4 +1,4 @@
-#!/nix/store/00000000000000000000000000000000-bash-5.1-p16/bin/bash
+#!/nix/store/00000000000000000000000000000000-bash-5.1-p12/bin/bash
 shopt -s expand_aliases
 
 # shellcheck disable=SC2142
For further reference please introspect /nix/store/hjxvnf979k037q74digq2k64w49z2n69-nmt-report-herbstluftwm-simple-config

mpd-basic-configuration: FAILED
Expected /nix/store/pgj4vjhihn3vsx4n9865w4ik3vaqklkf-nmt-report-mpd-basic-configuration/normalized/mpd.service to be same as /nix/store/6ix31n8jxwzq5rzmyk0vdh8jkhs65y9j-basic-configuration.service but were different:
--- actual
+++ expected
@@ -4,7 +4,7 @@
 [Service]
 Environment=PATH=/home/hm-user/.nix-profile/bin
 ExecStart=@mpd@/bin/mpd --no-daemon /nix/store/00000000000000000000000000000000-mpd.conf
-ExecStartPre=/nix/store/00000000000000000000000000000000-bash-5.1-p16/bin/bash -c "/nix/store/00000000000000000000000000000000-coreutils-9.0/bin/mkdir -p '/home/hm-user/.local/share/mpd' '/home/hm-user/.local/share/mpd/playlists'"
+ExecStartPre=/nix/store/00000000000000000000000000000000-bash-5.1-p12/bin/bash -c "/nix/store/00000000000000000000000000000000-coreutils-9.0/bin/mkdir -p '/home/hm-user/.local/share/mpd' '/home/hm-user/.local/share/mpd/playlists'"
 Type=notify
 
 [Unit]
For further reference please introspect /nix/store/pgj4vjhihn3vsx4n9865w4ik3vaqklkf-nmt-report-mpd-basic-configuration

I've also added myself as maintainer and to CodeOwners for notifications on related things, if it's OK for your? (#2815 for adding me as maintainer)

[SebTM]

Rebased (now including fixed tests) and added commit as mention in #2815 :)

stale