treewide: replace attrs by formats or types.anything#1595
treewide: replace attrs by formats or types.anything#1595rycee merged 1 commit intonix-community:masterfrom
Conversation
|
The build will fail because this hasn't been rebased on top of #1594 |
|
This has nothing to do with these changes. |
434dfe6 to
e868816
Compare
|
@rycee it would be great if this could move forward as |
|
Thanks! Looks good I think, I just got confused about the commented line. |
e868816 to
461ce6c
Compare
|
@rycee I just now remembered reading about a module that gave importance to the ordering of keys in its JSON configuration. |
461ce6c to
3091cb4
Compare
|
@berbiche I can't recall which one that might be but I don't think it is any of these since they all use |
3091cb4 to
44f9d68
Compare
|
Thanks! Merged to master, now that its clear that the test performance issue is unrelated. |
Description
Replaces all instances of:
types.attrswithtypes.attrsOf types.anythingwhere it made sensetypes.attrswithpkgs.format.{json,yaml,ini}where it made senseThere are places where replacing
types.attrsbroke the evaluation and so wasn't done:Checklist
Change is backwards compatible.
[x ] Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.