Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist list #3

Merged
merged 6 commits into from
Apr 10, 2023
Merged

hoist list #3

merged 6 commits into from
Apr 10, 2023

Conversation

blaggacao
Copy link
Contributor

  • refactor: let tranformers take a cursor to reason about depth
  • feat: optionally accept transformer list
  • docs: add configurable hoistLists transformer
  • test: add configurable hoistLists transformer
  • feat: add configurable hoistLists transformer

src/load.nix Show resolved Hide resolved
src/load.nix Outdated Show resolved Hide resolved
src/transformers/hoistLists.nix Outdated Show resolved Hide resolved
src/transformers/hoistLists.nix Outdated Show resolved Hide resolved
src/transformers/hoistLists.nix Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/transformers/hoistLists.nix Show resolved Hide resolved
tests/hoistLists/expr.nix Outdated Show resolved Hide resolved
@figsoda
Copy link
Member

figsoda commented Apr 10, 2023

btw some suggestions I made requires updating the let inherits

@blaggacao blaggacao force-pushed the hoist-list branch 2 times, most recently from 991770a to 65415ba Compare April 10, 2023 20:45
@blaggacao
Copy link
Contributor Author

Ok, I think I got all. Can you review again?

@blaggacao blaggacao requested a review from figsoda April 10, 2023 20:46
@figsoda figsoda merged commit 94d3322 into nix-community:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants