fix: overlapped local replacement #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One golang standalone module can exists inside another module, when we replace such module to local directory, we'll try to create symbolic link inside the source directory and `ln` complains permission denied. For example, both `cosmossdk.io/x/accounts` and `cosmossdk.io/x/accounts/defaults/lockup` are standalone modules, if we do `replace cosmossdk.io/x/accounts => ./x/accounts`, we'll try to create two symbolic links like this: ``` $ ln -s ./x/accounts vendor/cosmossdk.io/x/accounts $ ln -s ./x/accounts/defaults/lockup vendor/cosmossdk.io/x/accounts/defaults/lockup ``` And the second one is inside source directory and fails. The temporary solution here is to simply ignore the symbolic link error, not ideal, but fix the issue at hand, and should have not side effect on existing projects.
yihuang
commented
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One golang standalone module can exists inside another module, when we replace such module to local directory, we'll try to create symbolic link inside the source directory and
lncomplains permission denied.For example, both
cosmossdk.io/x/accountsandcosmossdk.io/x/accounts/defaults/lockupare standalone modules, if we doreplace cosmossdk.io/x/accounts => ./x/accounts, we'll try to create two symbolic links like this:And the second one is inside source directory and fails.
The temporary solution here is to simply ignore the symbolic link error, not ideal, but fix the issue at hand, and should have no side effect on existing projects.