Remove usage of filterSource in gomod2nix import #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running gomod2nix import, the calls to nix-instantiate fail with
the following error:
```
error:
… while calling the 'filterSource' builtin
at «string»:2:1:
1|
2| builtins.filterSource (name: type: baseNameOf name != ".DS_Store") (
| ^
3| builtins.path {
… while adding path '/nix/store/aiskw3qix131gdmdjnsywqcqpn7jjr6a-aws-sdk-go_v1.50.27'
error: path '/nix/store/aiskw3qix131gdmdjnsywqcqpn7jjr6a-aws-sdk-go_v1.50.27' is not valid
/nix/var/nix/profiles/default/bin/nix-instantiate --eval --expr
builtins.filterSource (name: type: baseNameOf name != ".DS_Store") (
builtins.path {
path = "/home/ianwork/go/pkg/mod/github.com/aws/[email protected]";
name = "aws-sdk-go_v1.50.27";
}
)
```
When looking at the docs, it appears the 'builtins.path' can take a
'filter', which also seems to be the preferred way: there are warnings
about using 'filterSource' in the docs:
https://nixos.org/manual/nix/stable/language/builtins.html#builtins-filterSource
After making this change, I no longer get the previous error on my
machine"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running gomod2nix import, the calls to nix-instantiate fail with the following error:
When looking at the docs, it appears the 'builtins.path' can take a 'filter', which also seems to be the preferred way: there are warnings about using 'filterSource' in the docs:
https://nixos.org/manual/nix/stable/language/builtins.html#builtins-filterSource
After making this change, I no longer get the previous error on my machine"