Skip to content

Fix Savannah snapshot downloads by switching from cgit to gitweb #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Fix Savannah snapshot downloads by switching from cgit to gitweb #523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repos/emacs/update
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function update_savannah_branch() {
version_number=$(echo $commit_data | cut -d '/' -f 2 | cut -d 'T' -f 1 | sed 's/-//g').0

output_branch=$(echo $branch | sed s/"\/"/"_"/)
digest=$(nix-prefetch-url --unpack "https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-${commit_sha}.tar.gz")
digest=$(nix-prefetch-url --unpack --name "emacs-${commit_sha}.tar.gz" "https://git.savannah.gnu.org/gitweb/?p=emacs.git;a=snapshot;h=${commit_sha};sf=tgz")
Copy link
Copy Markdown
Member

@jian-lin jian-lin Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially, the gitweb snapshot service is no more reliable than the cgit snapshot service. They may decide to also disable gitweb snapshot in the future.

What is more reliable here is the git protocol. We should use that instead. Our use cases should be covered well by fetchgit.

I think the fetcher in https://github.com/nix-community/emacs-overlay/blob/master/overlays/emacs.nix probably needs some adjustments as well. The above is only part of the fix, I guess.

Yes. Here we update info about source and we use this source info in overlays/emacs.nix.

NOTE: There's a GitHub mirror maintained by tarsius. It doesn't currently include the feature/igc branch, but it will once the GitHub actions next run.

I am not a fan of adding more indirection.

I checked a few repos and their cgit snapshot services are all disabled. CC @normalcea (author of NixOS/nixpkgs#435964 and NixOS/nixpkgs#427024)

echo "{\"type\": \"savannah\", \"repo\": \"emacs\", \"rev\": \"${commit_sha}\", \"sha256\": \"${digest}\", \"version\": \"${version_number}\"}" > emacs-$output_branch.json
}

Expand Down