overlays: use a better and clearer way to compose overlays#257
Merged
leungbk merged 2 commits intonix-community:masterfrom Oct 19, 2022
Merged
overlays: use a better and clearer way to compose overlays#257leungbk merged 2 commits intonix-community:masterfrom
leungbk merged 2 commits intonix-community:masterfrom
Conversation
jian-lin
force-pushed
the
fix-overlays
branch
from
3676336 to
72fd2c5
Compare
The old way of composing overlays addes an unnecessay overlay, which
breaks the packages attribute of the flake. To reduce the impact on
users, I make a workaround[1] for that, which has been merged. Now I
figure out the real fix, which is to change (_: super) to (_: {}).
Additionally, the old way is a bit confusing.
This patch fixes both issues by using a better and clearer way to
compose overlays.
Since the workaround is no longer needed after this patch, I revert
that in the next commit.
[1]: nix-community#256
This reverts commit 86e6052.
jian-lin
force-pushed
the
fix-overlays
branch
from
72fd2c5 to
46c6c90
Compare
jian-lin
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old way of composing overlays addes an unnecessay overlay, which
breaks the packages attribute of the flake. To reduce the impact on
users, I make a workaround1 for that, which has been merged. Now I
figure out the real fix, which is to change
(_: super)to(_: {}).Additionally, the old way is a bit confusing.
This patch fixes both issues by using a better and clearer way to
compose overlays.
Since the workaround is no longer needed after this patch, I revert
that in the next commit.
cc @leungbk