Split into two overlays: one for emacs and another for emacs packages#237
Merged
leungbk merged 3 commits intonix-community:masterfrom Oct 4, 2022
Merged
Conversation
jian-lin
force-pushed
the
pr/split-emacs-and-packages
branch
from
6632f4b to
1afd194
Compare
Member
|
Conceptually I like this but can you split the commit so that files are first moved and then edited? |
jian-lin
force-pushed
the
pr/split-emacs-and-packages
branch
from
1afd194 to
6cc1fbc
Compare
Member
Author
|
I split commits and hope that is what you mean. Note that there are references to default.nix in the hydra dir and in some tests. As a result,they are broken after my first commit, but my second commit fixs them. |
Member
Author
|
@leungbk Do you think this is good to merge if I rebase it? |
Member
|
@jian-lin Sounds good. Thanks for working on this. |
This is to prepare for splitting the overlay into two seperated ones.
jian-lin
force-pushed
the
pr/split-emacs-and-packages
branch
from
6cc1fbc to
1085763
Compare
Member
Author
|
@leungbk I think it's ready for review |
Emacs packages in nixpkgs have binary cache since [1]. It is useful to split the whole overlay into two seperated ones so that users can use emacs packages in nixpkgs with emacsWithPackagesFromUsePackage or emacsWithPackagesFromPackageRequires in this overlay. [1]: NixOS/nixpkgs#188110
jian-lin
force-pushed
the
pr/split-emacs-and-packages
branch
from
1085763 to
c91c353
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emacs packages in nixpkgs have binary cache since 1. It is useful to
split the whole overlay into two seperated ones so that users can use
emacs packages in nixpkgs with emacsWithPackagesFromUsePackage or
emacsWithPackagesFromPackageRequires in this overlay.