Add redirection support #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a source is redirected, Bundix::Fetcher will follow the redirection and use the new URL as the source URL. This is useful for sources that are hosted on GitHub, as GitHub will redirect to a CDN. Fixes nix-community#106
These tests cover the case where the Fetcher is redirected to a new location. The with_server method was re-written to allow for multiple requests and responses.
|
Just bumped into this issue as well. It would be great to get this moved forward |
|
@manveru Any chance this could get a review and merge? Running into the issue as well. |
Mic92
approved these changes
Nov 8, 2023
|
Code looks good to me and even has tests for the fixed issue. I would go ahead and merge this in a bit if there are no objections. |
marsam
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
This PR adds support for HTTPRedirection responses from servers that use CDNs, like Github private package repositories
The tests could be a lot cleaner if we were to use a library or framework to mock the HTTP requests and responses instead of running our own fake server.