Logging: change ?LOG
macro to ?WF_LOG
#142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised in #136. With props to @bunnylushington as I worked from your proposed solution.
See Slack discussion here: https://erlanger.slack.com/archives/CFV94TLCA/p1629216894001400
I have my doubts about two specifics:
LOG
when the OTP logger has not been included -- since the parameters differ, it might introduce a more confusing incompatibility than removing it entirely, and encouraging any consumers to move toWF_LOG
explicitly.I'm wondering if it might be better to avoid the
ifndef
entirely and force usage of the new logger -- would it make sense to importlogger.hrl
as a dependency of Nitrogen? (This may be a naive question, as I'm new to Nitrogen and to the Erlang ecosystem.)n.b. This PR does not update
wf:info
,wf:error
etc to use the new macro.@choptastic please let me know what you think, and what further work might be needed. Thanks!