expected output from wf:qs -> [] vs [[]]

[fnchooft]

Hi, I was running the "make test" target to see if a change I made was passing.

However I found that the test for multidropdownblank was failing.
The function returns [[]] instead of the expected [].

 test_multidropdownblank() ->
     {
         fun() -> wf:set_multiple(multiple, []) end,
-        fun() -> wf:qs(multiple) == [] end
+        fun() -> wf:qs(multiple) == [[]] end
     }.

https://github.com/nitrogen/NitrogenProject.com/blob/master/src/tests/tests_simplecontrols.erl#L75

The question now becomes - what is wf:qs supposed to return if there is no result?

It seems that:

• if the element with id=multiple is ON screen - and data is selected ( "1","3" ) - it returns ["1","3"]
• if the element with id=multiple is NOT ON screen - it returns []
• if the element with id=multiple is ON screen - without any selection - it returns [[]]

Could you confirm my understanding?

Kind regards,

Fabian

[choptastic]

Hi Fabian, It should be an empty list: `[]` I believe I have this fixed in the rebar3 branch, and just didn't port it back.

…

-Jesse

On Tue, Jan 3, 2023, 1:26 PM fnchooft ***@***.***> wrote: Hi, I was running the "make test" target to see if a change I made was passing. However I found that the test for multidropdownblank was failing. The function returns [[]] instead of the expected []. test_multidropdownblank() -> { fun() -> wf:set_multiple(multiple, []) end, - fun() -> wf:qs(multiple) == [] end - fun() -> wf:qs(multiple) == [[]] end }. https://github.com/nitrogen/NitrogenProject.com/blob/master/src/tests/tests_simplecontrols.erl#L75 The question now becomes - what is wf:qs supposed to return if there is no result? Kind regards, Fabian — Reply to this email directly, view it on GitHub <#15>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABNRHGUOG2TKK4ZINF4V5TWQR4ORANCNFSM6AAAAAATQANCZE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[fnchooft]

Hi Jesse, happy new year!
I will check the rebar3-branch.

Follow up question: Is there a timeline for this rebar3-transformation? :)

No hurries - but if so that would be great news!

Especially thinking about dependency mgmt - for instance jquery- jmobile, fileupload etc - maybe there is a way to make it a bit more configurable.