Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency of clients for obtaining connection #63

Closed
Shivam010 opened this issue Feb 16, 2022 · 3 comments · Fixed by #62
Closed

Remove direct dependency of clients for obtaining connection #63

Shivam010 opened this issue Feb 16, 2022 · 3 comments · Fixed by #62

Comments

@Shivam010
Copy link
Collaborator

go-redis provides 4 different types of protocols to connect to Redis

Similarly, Redigo provides a single method:

And as we only use Do method of both the clients. Hence, in order to support these different types of connections in each client, abstracting the required method is the only feasible option

Originally posted by @Shivam010 in #62 (comment)

@jaysonhurd
Copy link

Just FYI I'm leaving 53 for now since it looks like you are covering that here. I have a copy working with ClusterClient if you ever decide you need it. Once I get approval I can push the branch for reference.

Shivam010 added a commit that referenced this issue Feb 17, 2022
* Change go-redis client to universal client interface #53 

* Abstracts clients to support different types of redis connections

* Adding support for different types of connections provided by libraries #63
@Shivam010
Copy link
Collaborator Author

Yeah, firstly thanks @jaysonhurd for your contribution. Secondly, I don't think we're gonna need that anymore. Cause with the use of interface as a connection, one can use any connection type, it just needs to implement the corresponding Do method.

@jaysonhurd
Copy link

@Shivam010 Tested it and it works great with our ClusterClient connection. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants