-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct dependency of clients for obtaining connection #63
Comments
Just FYI I'm leaving 53 for now since it looks like you are covering that here. I have a copy working with ClusterClient if you ever decide you need it. Once I get approval I can push the branch for reference. |
Yeah, firstly thanks @jaysonhurd for your contribution. Secondly, I don't think we're gonna need that anymore. Cause with the use of interface as a connection, one can use any connection type, it just needs to implement the corresponding |
@Shivam010 Tested it and it works great with our ClusterClient connection. Thanks!! |
go-redis provides 4 different types of protocols to connect to Redis
Similarly, Redigo provides a single method:
And as we only use
Do
method of both the clients. Hence, in order to support these different types of connections in each client, abstracting the required method is the only feasible optionOriginally posted by @Shivam010 in #62 (comment)
The text was updated successfully, but these errors were encountered: