Skip to content

Fix XWPFTable row cannot insert to the last position of table #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 5 commits into from
Mar 4, 2023
Merged

Fix XWPFTable row cannot insert to the last position of table #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
100ab8d
Fix row cannot insert to the last position of the table
Jan 6, 2023
b209c29
Merge remote-tracking branch 'origin/master'
Jan 6, 2023
468d5b2
Rename test
Jan 6, 2023
e7f0417
Fix format
Jan 6, 2023
6ba4635
Remove AddNewRowBetween because the POI document said it is deprecated.
Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions OpenXmlFormats/Wordprocessing/Table.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,9 @@ private int GetItems1Index(Items1ChoiceType type, int p)
pos++;
}
}
// Check if the position should be the last position when index cannot be find in for loop
if( index == -1&&pos == p)
index = items1Field.Count;
return index;
}
private void RemoveItems1(Items1ChoiceType type, int p)
Expand Down
5 changes: 0 additions & 5 deletions ooxml/XWPF/Usermodel/XWPFTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,6 @@ public String Text
}
}

public void AddNewRowBetween(int start, int end)
{
throw new NotImplementedException();
}

/**
* add a new column for each row in this table
*/
Expand Down
31 changes: 31 additions & 0 deletions testcases/ooxml/XWPF/UserModel/TestXWPFTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,37 @@ public void TestCreateRow()
xtab = new XWPFTable(new CT_Tbl(), doc);
Assert.AreEqual(1, xtab.GetCTTbl().GetTrArray(0).SizeOfTcArray());
}
[Test]
public void TestInsertRow()
{
XWPFDocument doc = new XWPFDocument();

CT_Tbl table = new CT_Tbl();
CT_Row r1 = table.AddNewTr();
r1.AddNewTc().AddNewP();
r1.AddNewTc().AddNewP();
CT_Row r2 = table.AddNewTr();
r2.AddNewTc().AddNewP();
r2.AddNewTc().AddNewP();
CT_Row r3 = table.AddNewTr();
r3.AddNewTc().AddNewP();
r3.AddNewTc().AddNewP();

XWPFTable xtab = new XWPFTable(table, doc);
Assert.AreEqual(3, xtab.NumberOfRows);
Assert.IsNotNull(xtab.GetRow(2));

//add a new row
xtab.CreateRow();
Assert.AreEqual(4, xtab.NumberOfRows);

xtab.InsertNewTableRow(0);
Assert.AreEqual(5, xtab.NumberOfRows);
xtab.InsertNewTableRow(xtab.NumberOfRows);
Assert.AreEqual(6, xtab.NumberOfRows);


}

[Test]
public void TestSetGetWidth()
Expand Down