Skip to content

FormulaCellCacheEntry: Optimize ChangeConsumingCells method #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 2 commits into from
May 22, 2023
Merged

FormulaCellCacheEntry: Optimize ChangeConsumingCells method #939

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbeb0d3
FormulaCellCacheEntry: Optimize ChangeConsumingCells method
EmilienDup Oct 24, 2022
0f42409
Merge branch 'nissl-lab:master' into fix/FormulaCacheEntrySet-perf
EmilienDup Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions main/SS/Formula/FormulaCellCacheEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ limitations under the License.
namespace NPOI.SS.Formula
{
using System.Collections;
using System.Collections.Generic;
using NPOI.SS.Formula.Eval;


Expand Down Expand Up @@ -105,19 +106,27 @@ private void ChangeConsumingCells(CellCacheEntry[] usedCells)
{
return;
}
ArrayList usedSet;

HashSet<CellCacheEntry> usedSet;
if (nUsed < 1)
{
usedSet = new ArrayList();
usedSet = new HashSet<CellCacheEntry>();
}
else
{
usedSet = new ArrayList(nUsed * 3 / 2);

#if NETSTANDARD2_1_OR_GREATER || NET6_0_OR_GREATER
usedSet = new HashSet<CellCacheEntry>(nUsed * 3 / 2);
#else
usedSet = new HashSet<CellCacheEntry>();
#endif

for (int i = 0; i < nUsed; i++)
{
usedSet.Add(usedCells[i]);
}
}

for (int i = 0; i < nPrevUsed; i++)
{
CellCacheEntry prevUsed = prevUsedCells[i];
Expand Down