Fix: Add oldStr to StringBuilder before Remove operation in Replace#1656
Merged
tonyqus merged 1 commit intoDec 29, 2025
Merged
Conversation
Contributor
ZagidullinRuslanG
commented
Oct 30, 2025
ZagidullinRuslanG
commented
- The Replace function was creating an empty StringBuilder and immediately trying to remove characters from it, causing formula calculation to fail
- Added strBuff.Append(oldStr) to populate the buffer before modification
- Fixes issue with REPLACE formula in Excel spreadsheets
…unction nissl-lab#1655 - The Replace function was creating an empty StringBuilder and immediately trying to remove characters from it, causing formula calculation to fail - Added strBuff.Append(oldStr) to populate the buffer before modification - Fixes issue with REPLACE formula in Excel spreadsheets
Member
|
fix #1655 |
This was referenced Feb 27, 2026
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.