Poi bug 61532 & 61148#1645
Merged
Merged
Conversation
…rValue() in SXSSFCell are doing different things than the ones in XSSFCell, tried to fix this by mimicking functionality of XSSF in SXSSF as well.
…need to set the value twice Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF
…anges for bug 61148.
tonyqus
reviewed
Oct 7, 2025
| [Test] | ||
| public override void TestUpdateCachedFormulaResultFromErrorToNumber_bug46479() | ||
| { | ||
| Assume.That(false, "This test is disabled because it fails for SXSSF because " + |
Member
There was a problem hiding this comment.
What's going on with Bug46479 test case?
Collaborator
Author
There was a problem hiding this comment.
This is just ported from POI, which states that this test should be disabled. The test case will not fail if removing it from sub-class, and retaining it is only for consistency with POI.
tonyqus
reviewed
Oct 7, 2025
|
|
||
| [Test] | ||
| public void TestMultisheetFormulaEval() | ||
| { |
Member
There was a problem hiding this comment.
I see a few existing test cases are removed from TestHSSFCell. May I ask Why?
Collaborator
Author
There was a problem hiding this comment.
These test cases were moved to base class `BaseTestFormulaEvaluator, adding tests for the three HSSF, XSSF, SXSSF FormulaEvaluation test classes.
This was referenced Feb 27, 2026
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: