Skip to content

Fix SortCondition XML to match spec rules#1618

Merged
tonyqus merged 1 commit into
nissl-lab:masterfrom
brandscill:brandscill/fix-sortcondition-xml
Aug 7, 2025
Merged

Fix SortCondition XML to match spec rules#1618
tonyqus merged 1 commit into
nissl-lab:masterfrom
brandscill:brandscill/fix-sortcondition-xml

Conversation

@brandscill
Copy link
Copy Markdown

@brandscill brandscill commented Aug 6, 2025

#1616 - Fixes invalid XML for CT_SortCondition.

As per the spec this only writes:

  • dxfId when the sortBy is either a fontColor or cellColor
  • iconSet when the sortBy is icon
  • iconId when the sortBy is icon

@tonyqus tonyqus added this to the NPOI 2.7.5 milestone Aug 7, 2025
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Aug 7, 2025

LGTM

@tonyqus tonyqus merged commit aee1ddc into nissl-lab:master Aug 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants