Add support for embedded object extractor#1607
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for embedded object extraction in XSSF/OOXML format spreadsheets. The changes enable creation, reading, and extraction of OLE packages and embedded objects within Excel files, addressing several issues related to SSF embeddings and XSSF GroupShapes functionality.
Key Changes:
- Added embedded object extractor functionality with new EmbeddedExtractor and EmbeddedData classes
- Implemented OLE package embedding support in XSSFWorkbook with AddOlePackage method
- Enhanced drawing and shape handling with improved generic type safety using IDrawing
Reviewed Changes
Copilot reviewed 63 out of 66 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ooxml/XSSF/UserModel/XSSFObjectData.cs | New class implementing IObjectData for XSSF embedded objects |
| ooxml/XSSF/Extractor/EmbeddedExtractor.cs | New extractor class for identifying and extracting embedded documents |
| ooxml/XSSF/Extractor/EmbeddedData.cs | New data container class for embedded object information |
| main/SS/UserModel/IObjectData.cs | New interface defining common OLE shape behavior |
| ooxml/XSSF/UserModel/XSSFWorkbook.cs | Added AddOlePackage method for embedding OLE objects |
| multiple test files | Updated IDrawing type signatures to use generic IDrawing |
| OpenXmlFormats classes | Enhanced XML schema support for OLE objects and drawing elements |
Comments suppressed due to low confidence (2)
testcases/ooxml/XSSF/SXSSFITestDataProvider.cs:28
- Separate the using statements onto different lines for better readability and consistency with coding standards.
using NPOI.XSSF.UserModel;
testcases/ooxml/XSSF/SXSSFITestDataProvider.cs:34
- The [TestFixture] attribute is removed but this appears to be a test class. Verify that test discovery still works correctly without this attribute.
*/
Member
|
LGTM |
This was referenced Sep 30, 2025
This was referenced Dec 2, 2025
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#60519 - Extractor for *SSF embeddings
#60520 - Provide *SSF functionality via Common SS
#60521 - Enable nested XSSF GroupShapes and fix calculation of Client-/ChildAnchor
#60586 - Support embedding OLE1.0 package in XSSF / SS Common