Fix analysis errors related to non-concrete type usage#1547
Merged
Conversation
lahma
commented
Apr 19, 2025
| public static int GetVariantLength(long variantType) | ||
| { | ||
| long key = (int)variantType; | ||
| if (numberToLength.Contains(key)) |
Collaborator
Author
There was a problem hiding this comment.
compared this to Java version and there was actually a bug here, it should have been not contains -> -2
Collaborator
Author
|
Hmm.. did I accidentally also fix the Windows build 🤔 |
Member
|
I'm not sure if the Windows build issue is solved. Let's see |
Member
This was referenced Jul 30, 2025
This was referenced Dec 2, 2025
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better to return and use concrete types instead of abstract classes and interfaces as it performs better. Removed analysis ignore and fixed issues. Changes target non-public API so there should be no breaking changes to end users.
I also changed some iterator/enumerator usage more idiomatic foreach in places where analysis complained about using interface to iterate.