Skip to content

Use NET 9 SDK in GitHub Actions to compile solution#1544

Merged
tonyqus merged 1 commit into
nissl-lab:masterfrom
lahma:net9-sdk
Apr 18, 2025
Merged

Use NET 9 SDK in GitHub Actions to compile solution#1544
tonyqus merged 1 commit into
nissl-lab:masterfrom
lahma:net9-sdk

Conversation

@lahma
Copy link
Copy Markdown
Collaborator

@lahma lahma commented Apr 14, 2025

NET 9 has more analysis rules can currently fail build with NET 9 SDK locally where it still compiles under GH Actions. NET 9 SDK is more advanced compiler-wise and can also generate better code (especially for collection expressions).

@tonyqus tonyqus added the cicd label Apr 14, 2025
@tonyqus tonyqus added this to the NPOI 2.7.4 milestone Apr 14, 2025
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Apr 14, 2025

I see you start using CustomGitHubActionsAttribute

@lahma
Copy link
Copy Markdown
Collaborator Author

lahma commented Apr 14, 2025

Yes, this is required to make it possible to customize things and injecting the setup dotnet step.

@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Apr 18, 2025

LGTM

@tonyqus tonyqus merged commit 68ce268 into nissl-lab:master Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants