Fix pattern formatting - return correct field for pattern fill foreground#1543
Merged
Conversation
tonyqus
reviewed
Apr 14, 2025
| if (!_fill.IsSetPatternFill() || !_fill.GetPatternFill().IsSetFgColor()) | ||
| return null; | ||
| return new XSSFColor(_fill.GetPatternFill().bgColor); | ||
| return new XSSFColor(_fill.GetPatternFill().fgColor); |
Member
|
LGTM |
This was referenced Jul 30, 2025
This was referenced Dec 2, 2025
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class used to create conditional a formatting pattern is returning the wrong backing field for the FillForegroundColorColor property (it returns the background instead of the foreground).