Skip to content

Some patches from poi#1540

Merged
tonyqus merged 9 commits into
nissl-lab:masterfrom
antony-liu:poi/v3.17-patch2
Apr 19, 2025
Merged

Some patches from poi#1540
tonyqus merged 9 commits into
nissl-lab:masterfrom
antony-liu:poi/v3.17-patch2

Conversation

@antony-liu
Copy link
Copy Markdown
Collaborator

Main changes:
61060 - teach DataFormatter about conditional formatting rules with number formats
Add table style test cases
github-52: add ExcelToHtmlConverter method that works on InputStreams.
github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication.

@antony-liu antony-liu requested a review from Copilot April 10, 2025 12:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

main/SS/Util/CellReference.cs:640

  • The exception message incorrectly refers to 'Person' instead of the expected 'CellReference'. Please update the message to accurately reflect the object type.
else throw new ArgumentException("Object is not a Person");

main/SS/Formula/Functions/Match.cs:175

  • [nitpick] The updated error message now concatenates the eval object's string representation instead of its type name, which might reduce clarity during debugging. Consider including type information.
throw new Exception("Unexpected eval type (" + eval + ")");

@antony-liu antony-liu added this to the NPOI 2.7.4 milestone Apr 10, 2025
@antony-liu antony-liu added the poi label Apr 10, 2025
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Apr 18, 2025

Can you help solve the conflict?

@antony-liu
Copy link
Copy Markdown
Collaborator Author

The conflict resolved.

@tonyqus tonyqus added the bug label Apr 19, 2025
@tonyqus tonyqus merged commit b544e4e into nissl-lab:master Apr 19, 2025
2 of 3 checks passed
@antony-liu antony-liu deleted the poi/v3.17-patch2 branch June 30, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants