Some patches from poi#1540
Merged
Merged
Conversation
…no families defined
…. Thanks to Tony Zeng! This closes nissl-lab#52.
…*0.2, 2). Thanks to @FishMeat.
….pow() with multiplication. Thanks to Daniel Kuan! This closes nissl-lab#32.
There was a problem hiding this comment.
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
main/SS/Util/CellReference.cs:640
- The exception message incorrectly refers to 'Person' instead of the expected 'CellReference'. Please update the message to accurately reflect the object type.
else throw new ArgumentException("Object is not a Person");
main/SS/Formula/Functions/Match.cs:175
- [nitpick] The updated error message now concatenates the eval object's string representation instead of its type name, which might reduce clarity during debugging. Consider including type information.
throw new Exception("Unexpected eval type (" + eval + ")");
Member
|
Can you help solve the conflict? |
Collaborator
Author
|
The conflict resolved. |
This was referenced Jul 30, 2025
This was referenced Dec 2, 2025
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
61060 - teach DataFormatter about conditional formatting rules with number formats
Add table style test cases
github-52: add ExcelToHtmlConverter method that works on InputStreams.
github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication.