Add support for XDDF by antony-liu · Pull Request #1521 · nissl-lab/npoi

antony-liu · 2025-03-23T02:44:26Z

Fix #1143

These changes are mainly from POI 4.0.1

tonyqus · 2025-03-24T20:29:24Z

If this PR doesn't break any existing feature, I can directly merge this one to master branch

Bykiev · 2025-03-31T17:21:48Z

Tests should be fixed before merging

tonyqus · 2025-04-06T19:31:02Z

I'm working on XSLF namespace migration

XSLF namespace migration (PPTX) #1538

…ml.Chart.CT_ShapeProperties

antony-liu · 2025-04-09T10:04:58Z

Migrate XDDF from POI to NPOI, based on POI 4.0.1

antony-liu · 2025-04-09T10:05:33Z

I'm working on XSLF namespace migration

XSLF namespace migration (PPTX) #1538

GREAT!

tonyqus · 2026-02-27T09:52:43Z

I'd like to merge this after 2.7.6 release. Please help solve conflicts

# Conflicts: # OpenXmlFormats/Drawing/BaseTypes.cs # OpenXmlFormats/Drawing/Chart/Chart.cs # OpenXmlFormats/Drawing/ShapeEffects.cs # OpenXmlFormats/Drawing/ShapeLineProperties.cs # OpenXmlFormats/Drawing/TextCharacter.cs # OpenXmlFormats/Drawing/spreadsheetShape.cs # OpenXmlFormats/Spreadsheet/Sheet/CT_Table.cs # ooxml/XSSF/UserModel/Charts/XSSFDateAxis.cs

antony-liu · 2026-03-01T07:21:26Z

Conflicts resolved

Copilot

Pull request overview

Adds a large set of XDDF (DrawingML) usermodel types and supporting OpenXML format helpers to address #1143, including chart, text, and shape-related APIs.

Changes:

Introduces many new XDDF usermodel wrapper types (text + chart) and enum mappings to underlying OpenXML schema types.
Extends OpenXmlFormats generated classes with additional IsSet*, Unset*, and AddNew* helpers to support the new XDDF API surface.
Adds optional value helpers (Option<T>, ValueOption<T>) and a small numeric utility overload.

Reviewed changes

Copilot reviewed 114 out of 191 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
ooxml/XDDF/UserModel/Text/XDDFShapeAutoFit.cs	Adds shape autofit wrapper implementing `IXDDFAutoFit`.
ooxml/XDDF/UserModel/Text/XDDFNormalAutoFit.cs	Adds normal autofit wrapper with scale/reduction accessors.
ooxml/XDDF/UserModel/Text/XDDFNoAutoFit.cs	Adds no-autofit wrapper implementing `IXDDFAutoFit`.
ooxml/XDDF/UserModel/Text/XDDFHyperlink.cs	Adds hyperlink wrapper over `CT_Hyperlink`.
ooxml/XDDF/UserModel/Text/XDDFFont.cs	Adds font wrapper mapping `FontGroup` + `CT_TextFont`.
ooxml/XDDF/UserModel/Text/XDDFBulletStylePicture.cs	Adds picture bullet style wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletStyleNone.cs	Adds “no bullet” style wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletStyleCharacter.cs	Adds character bullet style wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletStyleAutoNumbered.cs	Adds autonumber bullet style wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletStyle.cs	Introduces `IXDDFBulletStyle` marker interface.
ooxml/XDDF/UserModel/Text/XDDFBulletSizePoints.cs	Adds bullet size in points wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletSizePercent.cs	Adds bullet size in percent wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletSizeFollowText.cs	Adds “follow text” bullet size wrapper.
ooxml/XDDF/UserModel/Text/XDDFBulletSize.cs	Introduces `IXDDFBulletSize` marker interface.
ooxml/XDDF/UserModel/Text/XDDFAutoFit.cs	Introduces `IXDDFAutoFit` interface.
ooxml/XDDF/UserModel/Text/UnderlineType.cs	Adds underline enum + ST mapping helpers.
ooxml/XDDF/UserModel/Text/TextContainer.cs	Introduces `ITextContainer` property resolution helpers.
ooxml/XDDF/UserModel/Text/TextAlignment.cs	Adds text alignment enum + ST mapping helpers.
ooxml/XDDF/UserModel/Text/TabAlignment.cs	Adds tab alignment enum + ST mapping helpers.
ooxml/XDDF/UserModel/Text/StrikeType.cs	Adds strike enum + ST mapping helpers.
ooxml/XDDF/UserModel/Text/FontAlignment.cs	Adds font alignment enum + ST mapping helpers.
ooxml/XDDF/UserModel/Text/CapsType.cs	Adds caps enum + ST mapping helpers.
ooxml/XDDF/UserModel/Text/AnchorType.cs	Adds anchor enum + ST mapping helpers.
ooxml/XDDF/UserModel/SystemColor.cs	Adds system color enum + ST mapping helpers.
ooxml/XDDF/UserModel/SchemeColor.cs	Adds scheme color enum + ST mapping helpers.
ooxml/XDDF/UserModel/RectangleAlignment.cs	Adds rectangle alignment enum + ST mapping helpers.
ooxml/XDDF/UserModel/PresetLineDash.cs	Adds preset line dash enum + ST mapping helpers.
ooxml/XDDF/UserModel/PenAlignment.cs	Adds pen alignment enum + ST mapping helpers.
ooxml/XDDF/UserModel/PathShadeType.cs	Adds path shade enum + ST mapping helpers.
ooxml/XDDF/UserModel/LineEndWidth.cs	Adds line end width enum + ST mapping helpers.
ooxml/XDDF/UserModel/LineEndType.cs	Adds line end type enum + ST mapping helpers.
ooxml/XDDF/UserModel/LineEndLength.cs	Adds line end length enum + ST mapping helpers.
ooxml/XDDF/UserModel/LineCap.cs	Adds line cap enum + ST mapping helpers.
ooxml/XDDF/UserModel/HasShapeProperties.cs	Adds `IHasShapeProperties` interface.
ooxml/XDDF/UserModel/CompoundLine.cs	Adds compound line enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/XDDFValueAxis.cs	Adds value axis wrapper with helper methods.
ooxml/XDDF/UserModel/Chart/XDDFTitle.cs	Adds title wrapper with rich-text support.
ooxml/XDDF/UserModel/Chart/XDDFSeriesAxis.cs	Adds series axis wrapper.
ooxml/XDDF/UserModel/Chart/XDDFRadarChartData.cs	Adds radar chart data wrapper + series implementation.
ooxml/XDDF/UserModel/Chart/XDDFPieChartData.cs	Adds pie chart data wrapper + series implementation.
ooxml/XDDF/UserModel/Chart/XDDFNumericalDataSource.cs	Adds numerical datasource interface with format code.
ooxml/XDDF/UserModel/Chart/XDDFManualLayout.cs	Adds manual layout wrapper with properties.
ooxml/XDDF/UserModel/Chart/XDDFLegendEntry.cs	Adds legend entry wrapper + text container implementation.
ooxml/XDDF/UserModel/Chart/XDDFLayout.cs	Adds layout wrapper with manual layout support.
ooxml/XDDF/UserModel/Chart/XDDFDateAxis.cs	Adds date axis wrapper.
ooxml/XDDF/UserModel/Chart/XDDFDataSource.cs	Adds datasource interfaces.
ooxml/XDDF/UserModel/Chart/XDDFChartLegend.cs	Adds chart legend wrapper, entries, and layout helpers.
ooxml/XDDF/UserModel/Chart/XDDFChartExtensionList.cs	Adds chart extension list wrapper.
ooxml/XDDF/UserModel/Chart/XDDFCategoryDataSource.cs	Adds category datasource interface.
ooxml/XDDF/UserModel/Chart/XDDFCategoryAxis.cs	Adds category axis wrapper.
ooxml/XDDF/UserModel/Chart/XDDFBarChartData.cs	Adds bar chart data wrapper + series implementation.
ooxml/XDDF/UserModel/Chart/ScatterStyle.cs	Adds scatter style enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/RadarStyle.cs	Adds radar style enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/MarkerStyle.cs	Adds marker style enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/LegendPosition.cs	Adds legend position enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/LayoutTarget.cs	Adds layout target enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/LayoutMode.cs	Adds layout mode enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/Grouping.cs	Adds grouping enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/DisplayBlanks.cs	Adds display blanks enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/ChartTypes.cs	Adds `ChartTypes` enum.
ooxml/XDDF/UserModel/Chart/BarGrouping.cs	Adds bar grouping enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/BarDirection.cs	Adds bar direction enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisTickMark.cs	Adds axis tick mark enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisTickLabelPosition.cs	Adds tick label pos enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisPosition.cs	Adds axis position enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisOrientation.cs	Adds axis orientation enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisLabelAlignment.cs	Adds label alignment enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisCrosses.cs	Adds axis crosses enum + ST mapping helpers.
ooxml/XDDF/UserModel/Chart/AxisCrossBetween.cs	Adds cross-between enum + ST mapping helpers.
ooxml/XDDF/UserModel/BlackWhiteMode.cs	Adds black/white mode enum + ST mapping helpers.
ooxml/POIXMLDocumentPart.cs	Adds a “committed” flag and short-circuit in `OnSave`.
ooxml/NPOI.OOXML.Core.csproj	Removes an item group entry for preset style xml non-include.
main/Util/Optional/ValueOption.cs	Adds `ValueOption<T>` optional for structs.
main/Util/Optional/OptionalExtensions.cs	Adds nullable-to-option helpers.
main/Util/Optional/Option.cs	Adds `Option<T>` optional for reference types.
main/Util/Number.cs	Adds `IsNumber(Type)` overload.
main/NPOI.Core.csproj	Adds folder include for optional utilities.
main/Common/UserModel/Fonts/FontPitch.cs	Adds font pitch enum + mapping helpers.
main/Common/UserModel/Fonts/FontInfo.cs	Adds `IFontInfo` abstraction.
main/Common/UserModel/Fonts/FontGroup.cs	Adds font groups and Unicode range heuristics.
main/Common/UserModel/Fonts/FontFamily.cs	Adds font family enum + mapping helpers.
OpenXmlFormats/Spreadsheet/Sheet/CT_Table.cs	Fixes table column list initialization + refactors column APIs.
OpenXmlFormats/Drawing/spreadsheetShape.cs	Removes duplicate spreadsheet CT_TextBody definition.
OpenXmlFormats/Drawing/TextParagraph.cs	Adds many `IsSet/Unset/Add/Remove` helpers for text objects.
OpenXmlFormats/Drawing/TextBullet.cs	Adds `UnsetStartAt` for autonumber bullets.
OpenXmlFormats/Drawing/Text.cs	Adds many `IsSet/Unset` helpers and default list init for text bodies.
OpenXmlFormats/Drawing/ShapeProperties.cs	Adds `Unset`/`IsSet` and a `Set()` copier; fixes method casing.
OpenXmlFormats/Drawing/Picture.cs	Changes picture fields to be nullable + adds parse support.
OpenXmlFormats/Drawing/Chart/ScatterChart.cs	Adds helper methods for series and chart arrays.
OpenXmlFormats/Drawing/Chart/RadarChart.cs	Adds helper methods for series creation/flags/arrays.
OpenXmlFormats/Drawing/Chart/PieChart.cs	Adds helper methods for series flags and vary colors.
OpenXmlFormats/Drawing/Chart/LineChart.cs	Adds helper methods for series and chart arrays.
OpenXmlFormats/Drawing/Chart/BarChart.cs	Adds helper methods for chart arrays, gap width, and series helpers.

Comments suppressed due to low confidence (2)

OpenXmlFormats/Drawing/Text.cs:1

These setters now always force *Specified = true even when assigning the schema default values. This changes serialization semantics (defaults will always be emitted) and removes the previous “set to default -> treat as unspecified” behavior. If callers relied on clearing attributes by setting defaults, this becomes impossible without explicit Unset* methods. Consider restoring conditional Specified handling or adding/using explicit UnsetLIns/UnsetTIns/… equivalents consistently.

OpenXmlFormats/Drawing/Text.cs:1

These setters now always force *Specified = true even when assigning the schema default values. This changes serialization semantics (defaults will always be emitted) and removes the previous “set to default -> treat as unspecified” behavior. If callers relied on clearing attributes by setting defaults, this becomes impossible without explicit Unset* methods. Consider restoring conditional Specified handling or adding/using explicit UnsetLIns/UnsetTIns/… equivalents consistently.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tonyqus · 2026-03-05T04:36:46Z

Can you help fix the issues suggested by Copilot?

antony-liu added 2 commits March 23, 2025 07:58

add support for XDDF

42e8bd7

Add XDDFColor* class, support for XDDF

eeb684f

tonyqus added this to the NPOI 2.9.0 milestone Mar 24, 2025

tonyqus added enhancement chart labels Mar 24, 2025

antony-liu added 4 commits March 25, 2025 17:52

WIP: support for XDDF，migrate XDDF*Properties class

7b8708e

WIP: migrate XDDFLine*Properties class

830042c

WIP: support for XDDF, finish all classes of XDDF/UserModel folder

09cf18a

Add missing files

9f64e40

antony-liu added 3 commits April 2, 2025 07:17

Add XDDFFont, XDDFHyperlink and XDDF text properties

ae67a61

Add XDDFText* classes

4e8b288

fix test cases

3610a64

antony-liu added 5 commits April 7, 2025 19:52

Add XDDF*ChartData classes

e26bf91

Add XDDFChartLegend

0011868

use OpenXmlFormats.Dml.CT_ShapeProperties instead of OpenXmlFormats.D…

02389ba

…ml.Chart.CT_ShapeProperties

Add XDDFChart

7173b05

Add test cases of XDDF

f04b2fe

antony-liu marked this pull request as ready for review April 9, 2025 10:04

Merge branch 'master' into poi/XDDF

385324f

tonyqus modified the milestones: NPOI 2.9.0, NPOI 3.0.0 Jun 2, 2025

tonyqus modified the milestones: NPOI 3.0.0, NPOI 2.8.0 Feb 27, 2026

tonyqus added xwpf xssf labels Mar 1, 2026

tonyqus requested a review from Copilot March 1, 2026 15:04

Copilot AI reviewed Mar 1, 2026

View reviewed changes

tonyqus assigned antony-liu Mar 5, 2026

antony-liu added 3 commits March 12, 2026 22:08

fixed by copilot suggestion

7805e8e

fix bug

40db84f

remove unused namespace

c081e9d

tonyqus merged commit 5c48309 into nissl-lab:master Mar 12, 2026
2 of 3 checks passed

This was referenced Apr 27, 2026

Bump NPOI from 2.7.5 to 2.8.0 mganss/ExcelMapper#339

Closed

Bump NPOI from 2.7.6 to 2.8.0 JLdgu/PhoneAssistant#247

Merged

dependabot Bot mentioned this pull request May 4, 2026

nuget: Bump NPOI from 2.7.3 to 2.8.0 yuseok-kim-edushare/PowerBuilder-Dw2document#9

Merged

dependabot Bot mentioned this pull request May 20, 2026

Bump NPOI from 2.7.3 to 2.8.0 jkindrix/NetXlsx#8

Closed

dependabot Bot mentioned this pull request Jun 1, 2026

Bump NPOI from 2.7.6 to 2.8.0 SkylineCommunications/Skyline.DataMiner.CICD.Validators#275

Open

Uh oh!

Conversation

antony-liu commented Mar 23, 2025 • edited by tonyqus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonyqus commented Mar 24, 2025

Uh oh!

Bykiev commented Mar 31, 2025

Uh oh!

tonyqus commented Apr 6, 2025

Uh oh!

antony-liu commented Apr 9, 2025

Uh oh!

antony-liu commented Apr 9, 2025

Uh oh!

tonyqus commented Feb 27, 2026

Uh oh!

antony-liu commented Mar 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonyqus commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

antony-liu commented Mar 23, 2025 •

edited by tonyqus

Loading