Account for image resolution units other than pixels per inch#1519
Merged
Conversation
Added logic to convert the resolution to "pixels per inch" for images which have it specified as "pixels per meter" or "pixels per centimeter".
Bykiev
approved these changes
Mar 31, 2025
Collaborator
Bykiev
left a comment
Bykiev
left a comment
There was a problem hiding this comment.
Hi, this your first-time contribution in NPOI, my congratulations!
Everything looks good to me, thank you!
Member
|
LGTM |
This was referenced Jul 30, 2025
This was referenced Dec 2, 2025
This was referenced Apr 2, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to convert the resolution to "pixels per inch" for images which have it specified as "pixels per meter" or "pixels per centimeter".