Skip to content

Reduce warning output during build and treat new warnings as errors #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 1 commit into from
Mar 18, 2025
Merged

Reduce warning output during build and treat new warnings as errors #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,38 @@
<PackageReleaseNotes>https://github.com/nissl-lab/npoi/discussions/1422</PackageReleaseNotes>
<Copyright>Nissl LLC</Copyright>
<PackageTags>xlsx xls Excel Word docx office ole</PackageTags>

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<PropertyGroup Label="XML Documentation" Condition=" '$(Configuration)' == 'Release' ">
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);CS0419</NoWarn> <!-- Ambiguous reference in cref attribute -->
<NoWarn>$(NoWarn);CS1570</NoWarn> <!-- XML comment has badly formed XML -->
<NoWarn>$(NoWarn);CS1572</NoWarn> <!-- XML comment has a param tag for XXX, but there is no parameter by that name -->
<NoWarn>$(NoWarn);CS1573</NoWarn> <!-- Parameter XXX has no matching param tag in the XML comment -->
<NoWarn>$(NoWarn);CS1574</NoWarn> <!-- XML comment has cref attribute xxx that could not be resolved -->
<NoWarn>$(NoWarn);CS1584</NoWarn> <!-- XML comment has syntactically incorrect cref attribute -->
<NoWarn>$(NoWarn);CS1587</NoWarn> <!-- XML comment is not placed on a valid language element -->
<NoWarn>$(NoWarn);CS1591</NoWarn> <!-- Missing XML comment for publicly visible type or member -->
<NoWarn>$(NoWarn);CS1734</NoWarn> <!-- XML comment on XXX has a paramref tag for YYY, but there is no parameter by that name -->
</PropertyGroup>

<PropertyGroup Label="Code Analysis">
<NoWarn>$(NoWarn);CS0108</NoWarn> <!-- XXX hides inherited member -->
<NoWarn>$(NoWarn);CS0114</NoWarn> <!-- XXX hides inherited member -->
<NoWarn>$(NoWarn);CS0162</NoWarn> <!-- Unreachable code detected -->
<NoWarn>$(NoWarn);CS0168</NoWarn> <!-- The variable XXX is declared but never used -->
<NoWarn>$(NoWarn);CS0169</NoWarn> <!-- Unreachable code detected -->
<NoWarn>$(NoWarn);CS0414</NoWarn> <!-- The field XXX is assigned but its value is never used -->
<NoWarn>$(NoWarn);CS0628</NoWarn> <!-- new protected member declared in sealed type -->
<NoWarn>$(NoWarn);CS0649</NoWarn> <!-- Field XXX is never assigned to -->
<NoWarn>$(NoWarn);CS0659</NoWarn> <!-- XXX overrides Object.Equals(object o) but does not override Object.GetHashCode() -->

<NoWarn>$(NoWarn);CS0612</NoWarn> <!-- XXX is obsolete -->
<NoWarn>$(NoWarn);CS0618</NoWarn> <!-- XXX is obsolete: deprecated POI XYZ -->

<NoWarn>$(NoWarn);SYSLIB0021;SYSLIB0051</NoWarn> <!-- Deprecated API usage -->
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions benchmarks/NPOI.Benchmarks/NPOI.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<NoWarn>$(NoWarn);SYSLIB0014</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion main/HPSF/Section.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ public int Size
}
catch(HPSFRuntimeException ex)
{
throw ex;
throw;
}
catch(Exception ex)
{
Expand Down
8 changes: 8 additions & 0 deletions testcases/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,12 @@
<LangVersion>latest</LangVersion>
</PropertyGroup>

<PropertyGroup Label="Code Analysis">
<NoWarn>$(NoWarn);CS0612</NoWarn> <!-- XXX is obsolete -->
<NoWarn>$(NoWarn);CS0618</NoWarn> <!-- XXX is obsolete: deprecated POI XYZ -->
<NoWarn>$(NoWarn);CS0162</NoWarn> <!-- Unreachable code detected -->
<NoWarn>$(NoWarn);CA2200</NoWarn> <!-- Re-throwing caught exception changes stack information -->
<NoWarn>$(NoWarn);SYSLIB0014</NoWarn> <!-- obsolete -->
</PropertyGroup>

</Project>