Skip to content

Patches from poi#1433

Merged
tonyqus merged 5 commits into
nissl-lab:masterfrom
antony-liu:poi/v3.16-patch8
Oct 19, 2024
Merged

Patches from poi#1433
tonyqus merged 5 commits into
nissl-lab:masterfrom
antony-liu:poi/v3.16-patch8

Conversation

@antony-liu
Copy link
Copy Markdown
Collaborator

@antony-liu antony-liu commented Oct 19, 2024

poi: #60520 - Provide *SSF functionality via Common SS
Remove test cases that have been removed in the POI
poi: assertEquals(false, ...) -> assertFalse(...)

@tonyqus tonyqus self-requested a review October 19, 2024 09:58
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Oct 19, 2024

Please list what's changed in the description

@antony-liu
Copy link
Copy Markdown
Collaborator Author

poi: #60520 - Provide *SSF functionality via Common SS

  • 增加了三个接口:IChildAnchor , IShapeContainer 和ISimpleShape,在HSSF和XSSF UserModel中的对应接口、类或继承、或实现,通过接口提供一致的访问。
  • HSSFShape实现IShape接口

remove test cases that have been removed in the POI

  • 删除POI中已删除的测试用例

poi: assertEquals(false, ...) -> assertFalse(...)

  • 把测试用例的断言 Assert.AreEqual(false, ...) 改为 Assert.IsFalse(...).
  • 把测试用例的断言 Assert.AreEqual(true, ...) 改为 Assert.IsTrue(...).

@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Oct 19, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants