Skip to content

Remove System.Configuration.ConfigurationManager as NuGet dependency#1400

Merged
tonyqus merged 1 commit into
nissl-lab:masterfrom
lahma:remove-configuration-manager
Aug 13, 2024
Merged

Remove System.Configuration.ConfigurationManager as NuGet dependency#1400
tonyqus merged 1 commit into
nissl-lab:masterfrom
lahma:remove-configuration-manager

Conversation

@lahma
Copy link
Copy Markdown
Collaborator

@lahma lahma commented Aug 9, 2024 •
edited
Loading

  • the dependency brings legacy packages (DLLs) with it to modern .NET
  • usages are for advanced cases and I'd argue rarely used
  • keep the support on full framework where .config files still are a thing
  • allow configuration via environment variables on non-framework platforms

Remove System.Configuration.ConfigurationManager as NuGet dependency
b1a758c 
* allow configuration via environment variables on non-framework platforms
@lahma
Copy link
Copy Markdown
Collaborator Author

lahma commented Aug 10, 2024

I just did for Quartz.NET too quartznet/quartznet#2513

@tonyqus tonyqus added this to the NPOI 2.7.2 milestone Aug 13, 2024
@tonyqus tonyqus added the cicd label Aug 13, 2024
@tonyqus tonyqus merged commit 731182f into nissl-lab:master Aug 13, 2024
@lahma lahma deleted the remove-configuration-manager branch August 14, 2024 01:22
This was referenced Dec 2, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Mar 2, 2026
Open
This was referenced Apr 2, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Bykiev Bykiev Bykiev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cicd

Projects

None yet

Milestone

NPOI 2.7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@lahma @Bykiev @tonyqus