Skip to content

UnhandledDataStructure should sanity check before allocating, not after #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 1 commit into from
Jul 3, 2024
+6 −2
Merged

UnhandledDataStructure should sanity check before allocating, not after #1377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scratchpad/HWPF/Model/UnhandledDataStructure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,17 @@ public class UnhandledDataStructure
public UnhandledDataStructure(byte[] buf, int offset, int length)
{
// Console.WriteLine("Yes, using my code");
_buf = new byte[length];
if (offset + length > buf.Length)
{
throw new IndexOutOfRangeException("buffer length is " + buf.Length +
"but code is trying to read " + length + " from offset " + offset);
}
Array.Copy(buf, offset, _buf, 0, length);
if(offset < 0 || length < 0)
{
throw new IndexOutOfBoundsException("Offset and Length must both be >= 0, negative " +
"indicies are not permitted - code is tried to read " + length + " from offset " + offset);
}
_buf = Array.Copy(buf, offset, _buf, 0, length);
}

internal byte[] GetBuf()
Expand Down