Skip to content

More patches ported from poi v3.16#1371

Merged
tonyqus merged 6 commits into
nissl-lab:masterfrom
antony-liu:poi/v3.16-patch7
Sep 22, 2024
Merged

More patches ported from poi v3.16#1371
tonyqus merged 6 commits into
nissl-lab:masterfrom
antony-liu:poi/v3.16-patch7

Conversation

@antony-liu
Copy link
Copy Markdown
Collaborator

More patches ported from poi v3.16

@tonyqus tonyqus added this to the NPOI 2.7.2 milestone Jun 26, 2024
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Aug 31, 2024

Can you check my review comments?

@antony-liu
Copy link
Copy Markdown
Collaborator Author

什么内容,没看到啊。

@tonyqus tonyqus self-requested a review September 5, 2024 07:30
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Sep 5, 2024

Can you see my reviews here?
image

@antony-liu
Copy link
Copy Markdown
Collaborator Author

This modification is based on the toString method in POI. The toString method in POI is gradually being adjusted to this form. Do you want to use StringBuilder in all ToString methods, or just use it here?

@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Sep 7, 2024

Just AS IS. No need to follow POI for this. We just follow POI for its feature.

Can you see other reviews?

@antony-liu
Copy link
Copy Markdown
Collaborator Author

No, I didn't see the previous comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants