Added support for \n in text elements#1346
Merged
Merged
Conversation
Collaborator
|
Can you please check failed tests? |
Member
|
any update? |
tonyqus
added a commit
to tonyqus/npoi
that referenced
this pull request
Oct 19, 2024
Author
|
@tonyqus sorry for the long wait, i checked in my environment and all units are working now. I also see that you fixed / finished my changes and merged them to main. Thanks for this, if you need any assistance on this issue please let me know. regards Pieter |
This was referenced Dec 2, 2025
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request for fixing #1260 for discussion on this change. (resolves #1260)
In short there are two changes:
I added a unit test to check that everything is replaced as expected.
Please let me know if i need to make additional changes.
Regards,
Pieter