Skip to content

Added support for \n in text elements#1346

Merged
tonyqus merged 1 commit into
nissl-lab:masterfrom
pbvs:master
Sep 22, 2024
Merged

Added support for \n in text elements#1346
tonyqus merged 1 commit into
nissl-lab:masterfrom
pbvs:master

Conversation

@pbvs
Copy link
Copy Markdown

@pbvs pbvs commented May 14, 2024

This is a pull request for fixing #1260 for discussion on this change. (resolves #1260)

In short there are two changes:

  1. When writing CT_Text to XML \n is replaced by the cml element <w:cr />
  2. When reading parsing xml the element <w:cr /> is replaced by \n
    I added a unit test to check that everything is replaced as expected.

Please let me know if i need to make additional changes.

Regards,
Pieter

@Bykiev
Copy link
Copy Markdown
Collaborator

Bykiev commented May 15, 2024

Can you please check failed tests?

@tonyqus tonyqus added this to the NPOI 2.7.2 milestone May 19, 2024
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Sep 22, 2024

any update?

@tonyqus tonyqus merged commit cbf48e5 into nissl-lab:master Sep 22, 2024
tonyqus added a commit to tonyqus/npoi that referenced this pull request Oct 19, 2024
@pbvs
Copy link
Copy Markdown
Author

pbvs commented Nov 8, 2024

@tonyqus sorry for the long wait, i checked in my environment and all units are working now. I also see that you fixed / finished my changes and merged them to main. Thanks for this, if you need any assistance on this issue please let me know.

regards Pieter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support adding line endings when a string containing \n is added to the document

3 participants