Do not include xfId in CellStyleXfs XML#1325
Merged
Merged
Conversation
Member
|
LGTM |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix removes the
xfIdattribute fromxfelements in thecellStyleXfscollection.When writing the
styles.xmlfile NPOI includes axfIdattribute in thexfelements of the cell style format collectionThe
xfIdattribute is meaningless incellStyleXfscollections. Thexfrecord is also used in thecellXfscollection wherexfIdis an index intocellStyleXfs.If you load a generated file into Excel and save it the
xfIdis stripped out ofcellStyleXfselements.Unfortunately, inclusion of the
xfIdattribute in thecellStyleXfscollection can cause other applications to fail. Spotfire will not read a file created with NPOI. Spotfire usesSyncfusion.XlsIO.Implementation.XmlReaders.Excel2007Parsewhich will crash if anxfIdis present onxfrecords in acellStyleXfscolllection. Spotfire will read files once the fix in this PR is applied.