Skip to content

Workbook Evaluator bug fix on checking an IF without a third param #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 2 commits into from
Oct 11, 2023
Merged

Workbook Evaluator bug fix on checking an IF without a third param #1176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b23c3ec
Workbook Evaluator bug fix on checking an IF without a third param
fred2020-net Sep 5, 2023
6c55dc6
Merge branch 'nissl-lab:master' into master
fred2020-net Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main/SS/Formula/WorkbookEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ public ValueEval EvaluateFormula(OperationEvaluationContext ec, Ptg[] ptgs)
((FuncVarPtg)nextPtg).FunctionIndex == FunctionMetadataRegistry.FUNCTION_INDEX_IF)
{
// this is an if statement without a false param (as opposed to MissingArgPtg as the false param)
i++;
//i++;
stack.Push(arg0);
stack.Push(BoolEval.FALSE);
}
Expand Down