Skip to content

Fix XSSFSheet.RemoveHyperlink method.#1171

Merged
tonyqus merged 2 commits into
nissl-lab:masterfrom
jake-codes-at-5-am:fix-xssfsheet-removehyperlink
Aug 24, 2023
Merged

Fix XSSFSheet.RemoveHyperlink method.#1171
tonyqus merged 2 commits into
nissl-lab:masterfrom
jake-codes-at-5-am:fix-xssfsheet-removehyperlink

Conversation

@artemkoloskov-admin
Copy link
Copy Markdown
Contributor

The method wasn't removing the hyperlinks from CT_Hyperlinks array, only from a list in the hyperlinks property. Now it removes the hyperlink in both places.

Related to #1128

Updated the test for #690 to make sure the correct link is removed by the method.

@tonyqus tonyqus added this to the NPOI 2.6.2 milestone Aug 24, 2023
@tonyqus tonyqus added bug file_error file format generation/writing issue xssf labels Aug 24, 2023
Copy link
Copy Markdown
Collaborator

@Bykiev Bykiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyqus tonyqus merged commit b5f312f into nissl-lab:master Aug 24, 2023
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Aug 24, 2023

cherry-pick to release 2.6.2 branch is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug file_error file format generation/writing issue xssf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants