Skip to content

Remove reflections in POI Logger#1162

Merged
tonyqus merged 1 commit into
nissl-lab:aotfrom
karakasa:remove_reflection_poilogger
Oct 11, 2023
Merged

Remove reflections in POI Logger#1162
tonyqus merged 1 commit into
nissl-lab:aotfrom
karakasa:remove_reflection_poilogger

Conversation

@karakasa
Copy link
Copy Markdown
Contributor

@karakasa karakasa commented Aug 12, 2023

The original impl doesn't look quite right. For example, Type.GetType requires FullName but fed with Name. Nevertheless, a custom factory class is now required to eliminate reflections.

This will be a breaking change if the user uses custom logger.

@karakasa karakasa marked this pull request as ready for review August 12, 2023 06:12
@tonyqus tonyqus changed the base branch from master to aot August 13, 2023 14:20
@tonyqus tonyqus added this to the NPOI 2.7.1 milestone Aug 13, 2023
@tonyqus tonyqus added the aot label Aug 17, 2023
@tonyqus tonyqus merged commit 4eeb827 into nissl-lab:aot Oct 11, 2023
@karakasa karakasa deleted the remove_reflection_poilogger branch October 12, 2023 03:34
@tonyqus tonyqus modified the milestones: NPOI 2.7.1, NPOI AOT May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants