Remove reflections in POIFS.Crypt#1160
Merged
tonyqus merged 2 commits intoAug 29, 2023
Merged
Conversation
karakasa
changed the title
POIFS.CryptPOIFS.Crypt and motion to move Agile encryption algo into core library
karakasa
commented
Aug 12, 2023
karakasa
changed the title
POIFS.Crypt and motion to move Agile encryption algo into core libraryPOIFS.Crypt
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code uses dynamic type loading from loaded assemblies. This PR converts it into static dispatch.
NPOI.POIFS.Crypt.Agile.AgileEncryptionInfoBuilderis kind of special as it is from theNPOI.OOXMLassembly. Annotate the builder method with aDynamicDependencyattribute.