Skip to content

Update Text.cs to handle StringEval in arg0#1131

Merged
tonyqus merged 3 commits into
nissl-lab:masterfrom
fred2020-net:master
Jul 27, 2023
Merged

Update Text.cs to handle StringEval in arg0#1131
tonyqus merged 3 commits into
nissl-lab:masterfrom
fred2020-net:master

Conversation

@fred2020-net
Copy link
Copy Markdown
Contributor

In excel, this text function can also be used with strings (not only numeric values)

fred2020-net and others added 2 commits July 26, 2023 16:29
In excel, this text function can also be used with strings (not only numeric values)
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Jul 26, 2023

Instead of removing the test case, can you update it to the correct one?

@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Jul 26, 2023
@fred2020-net
Copy link
Copy Markdown
Contributor Author

Thanks @tonyqus for your feedback. The test is updated now.

@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Jul 27, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants